Add Trusted Firmware M wolfCOSE attestation patch#349
Draft
aidangarske wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Open Source Program (OSP) entry for Trusted Firmware‑M v2.3.0 that introduces an optional wolfCOSE-based initial attestation signing backend while preserving the default t_cose behavior when unselected.
Changes:
- Adds a TF‑M v2.3.0 patch that introduces a
TFM_COSE_BACKENDselector and a wolfCOSE signing implementation that delegates signing topsa_sign_hash(IAK not exported). - Adds TF‑M build integration for wolfCOSE/wolfCrypt sources under
lib/ext/wolfcose/. - Documents the Trusted Firmware‑M patch naming convention and where to find apply instructions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| trusted-firmware-m/2.3.0/trusted-firmware-m-2.3.0-wolfcose.patch | TF‑M v2.3.0 patch adding a selectable wolfCOSE backend for initial attestation token signing and associated build glue. |
| trusted-firmware-m/2.3.0/README | Introduces basic documentation for TF‑M patch storage/naming and where apply instructions live. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aidangarske
marked this pull request as ready for review
July 22, 2026 21:07
aidangarske
force-pushed
the
tfm-wolfcose
branch
2 times, most recently
from
July 22, 2026 22:17
81b1030 to
08a4752
Compare
Replaces t_cose with wolfCOSE in TF-M's initial attestation partition, so the
Entity Attestation Token is built and signed by wolfCOSE and wolfCrypt. t_cose
is no longer fetched or built.
Apply against a clean TF-Mv2.3.0 checkout:
git apply trusted-firmware-m-2.3.0-wolfcose.patch
Then build the SPE with the wolfSSL and wolfCOSE source paths:
-DWOLFSSL_PATH=<wolfssl> -DWOLFCOSE_PATH=<wolfCOSE>
Verified on QEMU mps2-an521 with the tf-m-tests regression suite passing and
zero t_cose symbols in the secure image.
aidangarske
force-pushed
the
tfm-wolfcose
branch
from
July 22, 2026 22:18
08a4752 to
33a91b3
Compare
aidangarske
marked this pull request as draft
July 22, 2026 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New OSP entry for Trusted Firmware-M, patch against the TF-Mv2.3.0 tag. Replaces t_cose with wolfCOSE for initial attestation token signing.
The IAK is never exported. wolfCOSE gets a signature callback that calls
psa_sign_hash, so the key stays in the crypto partition. wolfCrypt does the SHA-256.Adds a
TFM_COSE_BACKENDselector defaulting tot_cose, so an unselected build is unchanged. Backend specific code is in new files to keep the patch easy to re cut on TF-M releases.Testing: tf-m-tests TF-Mv2.3.0 regression suite on QEMU mps2-an521 with BL2 on passes 200/0, matching stock t_cose. Attestation partition links zero t_cose symbols. Real t_cose still verifies the wolfCOSE produced token in the test suite.
Depends on wolfSSL/wolfCOSE#59 for
WOLFCOSE_ENABLE_EXT_SIGN.